Scroll to comment on click through
Reported by Jeff Smick | April 30th, 2008 @ 06:04 PM
Comments already have ID attributes in the li tag so that part's done. How about appending "#comment_#{id}" to the end of the click through URL in a feed so the browser scrolls directly to the comment?
example:
http://github.com/rails/rails/co...
ensures defunkt's comment on that commit is visible
Comments and changes to this ticket
-
defunkt July 8th, 2008 @ 04:35 PM
- → State changed from “new” to “resolved”
- → Tag changed from “” to “comments feature ui”
Should be done.
-
Jeff Smick July 8th, 2008 @ 05:39 PM
Almost.
On my dashboard I'm in https and the comment link points at an https link. When I click it, I'm sent to the https page, then redirected to the non-https page with "#comments" removed from the end of the URL.
The link also only goes to the top of the comments section and not directly to the comment. Is that by design?
Finally, thanks for adding the feature.
-
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
