GitHub

Comments and changes to this ticket

• 

  Tom Preston-Werner July 13th, 2008 @ 01:26 PM

  • → State changed from “new” to “open”
  • → Assigned user changed from “” to “Tom Preston-Werner”

  Full commit messages are shown on the commit pages. See:

  http://github.com/rails/rails/co...

  Am I misunderstanding your ticket?

• 

  Matt Buck July 16th, 2008 @ 12:52 AM

  I've noticed the behavior he's referring to. I use TextMate as my commit message editor, but only the first line of my commit message shows up in the GitHub interface.

  I've uploaded a picture of one of the commit messages I'm referring to, along with the output of my local commit log.

  commit 0b4d43f2c56b87f25009c87d86214bd6890c05cc

  Author: Matt Buck

  Date: Fri Jul 11 18:56:51 2008 -0500

  • Removed a few extraneous gem includes.
  • Removed yet another call to ar_mailer.
• 

  Michał Roszka July 16th, 2008 @ 08:19 AM

  I have just redone all steps as follows.

  1. @~/.gitconfig attached
  2. Create a private repository,
  3. $ git init
  4. Put some files (I have a fresh copy of CakePHP, 164 files)
  5. Create .gitignore (attached)
  6. $ git add .
  7. $ git commit
  8. Then vim shows up
  9. Type a commit message (attached)
  10. Quit vim
  11. @git remote add origin git@github.com:mroszka/myrepo.git@
  12. git push origin master
  13. go to the commits history page -- only the first line of the commit message is shown (which is an expected behaviour)
  14. go to the single commit page -- I am getting 'Sorry, this commit is taking too long to generate.' (which is kind of expected behaviour), but there is no commit message shown at all. Not even the first line.

  My first thought was: OK, maybe the commit message is not supposed to be shown here at all, but it would be great to see the rest of it somewhere. That was why I have had submitted this ticket as a feature request.

  Now I know that multi-line commit messages are supported, but it would be great if they were displayed even if the diff is taking too long to generate. From $ git log maybe?

• 

  Michał Roszka July 17th, 2008 @ 08:00 AM

  One more case (successful this time). The settings and the repository are the same as they were in the case above. I have added 96 new files, then commited changes (multi-line commit message written in vim) and eventually pushed.

  Everything went pretty well. The multi-line commit messages is displayed correctly. There is an issue though. Firefox (Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9) Gecko/2008061015 Firefox/3.0, Ubuntu 8.04) is moaning (as attached) while rendering the single commit page.

• 

  Tom Preston-Werner July 26th, 2008 @ 01:22 PM

  Matt, the commit list page only shows the first line. If you click on the commit you will see the full commit message.

• 

  Tom Preston-Werner July 26th, 2008 @ 01:25 PM

  • → State changed from “open” to “resolved”

  Michael, your request for better handling of large commits is covered in #177